Fix empty slot detection never firing - #89
Open
damilolaedwards wants to merge 1 commit into
Open
Conversation
getBlock returns a nil block with a nil error on a 404, but the only caller detecting empty slots checked the error message for "404" instead. Since the error was already nil by the time it got there, that branch was unreachable and empty slot events never fired. The check now looks at the returned block instead of the error. Also pulled the empty slot check into its own method so it can be tested directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getBlock returns a nil block with a nil error on a 404, but the only caller detecting empty slots checked the error message for "404" instead. Since the error was already nil by the time it got there, that branch was unreachable, so OnEmptySlot never fired and the beacon_empty_slots counter was permanently zero whenever DetectEmptySlots was enabled.
Fix checks the returned block instead of the error. Also pulled the check into its own method so it can be tested directly.
Test plan